CMakeLists.txt: Respect user's libdir #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, on systems where /usr/lib64/ is used (e.g. Gentoo), libraries are installed to /usr/lib/ despite the standard CMake arguments being passed. It's not exactly clear what *the* canonical way is to take libdir parameters in CMake, but GNUInstallDirs mostly handles it for the *NIX case. To be minimally invasive here, I've only changed the *NIX path and aligned as much of the logic as possible. Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Feb 27, 2021
URL: wgois/OIS#69 Signed-off-by: Sam James <sam@gentoo.org>
|
Thanks, seems good. Gonna merge that now. |
|
Thanks a bunch @Ybalrid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, on systems where /usr/lib64/ is used
(e.g. Gentoo), libraries are installed
to /usr/lib/ despite the standard CMake arguments
being passed.
It's not exactly clear what the canonical way
is to take libdir parameters in CMake, but
GNUInstallDirs mostly handles it for the *NIX case.
To be minimally invasive here, I've only changed
the *NIX path and aligned as much of the logic as possible.
Signed-off-by: Sam James sam@gentoo.org
Summary of changes
Honour CMAKE_INSTALL_LIBDIR to ensure we install libraries to the correct path on different Linux distributions which choose a different lib/lib64 layout.
Affected backends
Build system (CMake)