Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Delete button when only Default reading list selected. #5378

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Disable Delete button when only Default reading list selected. #5378

merged 1 commit into from
Mar 5, 2025
+13 −20

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Mar 5, 2025

This cleans up the logic of enabling/disabling the ActionMode icons based on which reading lists are selected.

  • If no lists are selected, the Delete and Export buttons are disabled (and half-opacity).
  • If only the default Saved list is selected, the Delete button is disabled, and the Export button is enabled.
  • If more than one list is selected (which may include the default Saved list), the Delete and Export buttons are enabled.

https://phabricator.wikimedia.org/T387931

@dbrant dbrant added the Minor Minor stuff label Mar 5, 2025
@Williamrai Williamrai merged commit 7f9766e into main Mar 5, 2025
2 checks passed
@Williamrai Williamrai deleted the defaultListLogic branch March 5, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooltey cooltey

@Williamrai Williamrai

@voyagerfan voyagerfan

Assignees
No one assigned
Labels
Minor Minor stuff
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbrant @Williamrai