Skip to content

fix: change access signature to Astro.session #11460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

ematipico
Copy link
Member

Description (required)

This PR fixes the call of Astro.session and ctx.session. The session object might be undefined, so we need the ? to gracefully handle its access.

Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 03aef5c
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67fe758744fd500008c15054
😎 Deploy Preview https://deploy-preview-11460--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/integrations-guide/cloudflare.mdx Source changed, localizations will be marked as outdated.
en/guides/sessions.mdx Source changed, localizations will be marked as outdated.
en/reference/api-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ematipico ematipico merged commit e1fff9e into main Apr 15, 2025
11 checks passed
@ematipico ematipico deleted the fix/astro-session-signature branch April 15, 2025 15:21
yanthomasdev added a commit to jsparkdev/astro-docs that referenced this pull request Apr 15, 2025
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Apr 15, 2025
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Apr 15, 2025
Nin3lee added a commit to Nin3lee/docs that referenced this pull request Apr 24, 2025
Nin3lee added a commit to Nin3lee/docs that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants