Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup preparatory step #1582

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

pythcoiner
Copy link
Collaborator

I open this PR as a mid-step of #1576, as these commits are now ready for review and not likely to change.

This PR:

  • Implement export of PSBTs
  • Implement export of Descriptor
  • Implement export of Labels in BIP-0329 format
  • Implement export of PSBTs
  • Implement export of Descriptor
  • add receive_index and change_index to Daemon.get_info() result
  • add get_labels_bip329() to Daemon trait
  • implement wallet backup/export feature
  • Integrate the exports & backup feature to the settings panel (GUI)
  • Integrate the backup feature at wallet descriptor backup step (Installer)

223dae2 depends on this PR on our backend

@pythcoiner pythcoiner changed the title Backup preparatory Backup preparatory step Mar 8, 2025
@pythcoiner pythcoiner mentioned this pull request Mar 8, 2025
24 tasks
@pythcoiner pythcoiner force-pushed the backup_part1 branch 2 times, most recently from e8abce0 to a0f5723 Compare March 8, 2025 15:08
@pythcoiner
Copy link
Collaborator Author

comment addressed + done some rebase cleanup (clippy not passing between commits)

@pythcoiner pythcoiner force-pushed the backup_part1 branch 3 times, most recently from faa97a5 to e92b1c7 Compare March 10, 2025 19:21
@pythcoiner
Copy link
Collaborator Author

updated DUMP_LABELS_LIMIT to fit the limit added on backend

@pythcoiner
Copy link
Collaborator Author

added default-features = false to bip329 dependency

@pythcoiner
Copy link
Collaborator Author

Note: I just find out that the modal is not displayed at backup descriptor step in installer, I'm going to fix this

@pythcoiner pythcoiner force-pushed the backup_part1 branch 2 times, most recently from 13a3c0a to 7b5d156 Compare March 12, 2025 05:25
@pythcoiner
Copy link
Collaborator Author

Note: I just find out that the modal is not displayed at backup descriptor step in installer, I'm going to fix this

fixed + added a part of a commit that had "jump forward" in the commit history

@pythcoiner pythcoiner force-pushed the backup_part1 branch 2 times, most recently from bd916e1 to db65943 Compare March 12, 2025 16:43
&mut self,
_hws: &mut HardwareWallets,
message: Message,
ctx: &Context,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative to adding the ctx parameter to the update() method, could you instead add a context field to BackupDescriptor and use the load_context() method to set its value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the actual way we are sure to not forget to update the context imho

@pythcoiner
Copy link
Collaborator Author

The provider UUID and name will also now be saved, in addition to the key UUID and token.

yes will start to rebase

@pythcoiner
Copy link
Collaborator Author

rebased on master + backup providers keys metadata

@pythcoiner
Copy link
Collaborator Author

comments addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants