-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backup preparatory step #1582
base: master
Are you sure you want to change the base?
Backup preparatory step #1582
Conversation
e8abce0
to
a0f5723
Compare
a0f5723
to
670a2db
Compare
comment addressed + done some rebase cleanup (clippy not passing between commits) |
faa97a5
to
e92b1c7
Compare
updated |
e92b1c7
to
1e3bdc4
Compare
added |
Note: I just find out that the modal is not displayed at backup descriptor step in installer, I'm going to fix this |
13a3c0a
to
7b5d156
Compare
fixed + added a part of a commit that had "jump forward" in the commit history |
bd916e1
to
db65943
Compare
&mut self, | ||
_hws: &mut HardwareWallets, | ||
message: Message, | ||
ctx: &Context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an alternative to adding the ctx
parameter to the update()
method, could you instead add a context
field to BackupDescriptor
and use the load_context()
method to set its value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using the actual way we are sure to not forget to update the context imho
yes will start to rebase |
db65943
to
937ab54
Compare
937ab54
to
f542458
Compare
rebased on master + backup providers keys metadata |
f542458
to
1559aac
Compare
comments addressed |
I open this PR as a mid-step of #1576, as these commits are now ready for review and not likely to change.
This PR:
receive_index
andchange_index
toDaemon.get_info()
resultget_labels_bip329()
toDaemon
trait223dae2 depends on this PR on our backend