Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usermod v2 http pull light control 0.0.4 #3527

Conversation

roelbroersma
Copy link

Update of 0.0.3 but with SHA1 support for the HASH, which is better than the old FOWler hash which had a maximum of 10 digits. SHA1 is supported on ESP32 and ESP8266 (even though it are different core libraries).

@softhack007 softhack007 added the usermod usermod related label Nov 21, 2023
@blazoncek
Copy link
Collaborator

There are now 2 PRs for similar thing. Which is the correct one?

@roelbroersma
Copy link
Author

This is the new version v.0.0.4, the previous one is v.0.0.3.

You can first integrate version 0.0.3 and then this 0.0.4, which has as better hash method. Maybe in future there will be a v0.0.5 :)

@blazoncek
Copy link
Collaborator

What would be the purpose of merging 0.0.3 first and then 0.0.4? Why not just 0.0.4?

@roelbroersma
Copy link
Author

What would be the purpose of merging 0.0.3 first and then 0.0.4? Why not just 0.0.4?

Nothing, beside having some administrative history.
You can also close the request for v0.0.3 and do version v0.0.4.

@roelbroersma
Copy link
Author

Hi @blazoncek , what do you propose I'll do when in the meantime I have updates? I first did a pull-request for v.0.0.3, then (even before that pull-request was merged), I did a new pull-request for v0.0.4 (this one). And actually... today I just made a v0.0.5 which fixes some invalid JSON handling and always releasing the buffer (which could have not been done in rare circumstances).

Do you want me to do a pull request for that? 🙄😃

@blazoncek
Copy link
Collaborator

If these are progressive updates I see no point in opening different PRs.
Just push your changes to your current branch and the PR will update automatically.

You can also close 0.0.3 for that matter.

@roelbroersma
Copy link
Author

Closed because of the new v0.0.5.
See: #3560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usermod usermod related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants