This repository was archived by the owner on Jan 26, 2019. It is now read-only.
fix(typescriptTransform): Let tsc read the config instead of using 'require' #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g it Requiring the config does not support tsconfig options like "extends", which is useful for using multiple configs on a single project.
This was referenced Jul 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm currently migrating one of my playground projects to use CRA as a base.
While adopting everything, I've spotted a problem with the typescript transformation process.
Although the
tsconfigis in JSON format, it may contain theextendsoption for configuration inheritance. In that case, using plainrequirewould lead to an unexpected result.Example:
tsconfig for dev and build
tsconfig for test
The config for dev and build uses
module: "es2015"for tree-shaking, while the one for tests usesmodule: "commonjs", since the tests won't work with the first option. However, every other option should remain untouched, thus - configuration inheritance.Using the
readConfigFilefunction correctly follows theextendsreference and thus allows to use different configs for dev/build and test.(Don't mind that the referenced project does not build correctly (yet), still working on it ...)