fix: outer_env issues fixed #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/fix/envissues
branch
from
03e9762 to
827c8cf
Compare
Closed
henryiii
force-pushed
the
henryiii/fix/envissues
branch
from
87f0848 to
d52592c
Compare
henryiii
force-pushed
the
henryiii/fix/envissues
branch
2 times, most recently
from
9fe8f05 to
356ff7e
Compare
henryiii
force-pushed
the
henryiii/fix/envissues
branch
2 times, most recently
from
7e2dfcd to
09217ba
Compare
DiddiLeija
approved these changes
Jan 13, 2025
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/envissues
branch
from
09217ba to
c747bc1
Compare
Not sure about that, it's been open for nearly three months. ;) |
|
Yup, that's true, I was just a little concerned about some spots, but I've re-checked and everything is ok! |
|
Thanks! |
edopao
added a commit
to C2SM/icon4py
that referenced
this pull request
Feb 17, 2025
Read icon4py variable from OS environment, not nox environment. This became necessary after the nox version was upgraded. Refer to nox PR wntrblm/nox#874
edopao
added a commit
to GridTools/gt4py
that referenced
this pull request
Feb 17, 2025
Contains two types of changes: - Cleanup of `DOCKER_BUILD_ARGS`: this variable is passed to the docker build, but not used, which occasionally triggers an unnecessary rebuild. - As consequence of `DOCKER_BUILD_ARGS` cleanup the base image has been rebuilt. In the new image we pull a new nox version, which removes the os environment variables from the nox session environment (refer to nox PR wntrblm/nox#874). Therefore, such variables need to be read from the os environment.
edopao
added a commit
to C2SM/icon4py
that referenced
this pull request
Mar 6, 2025
Read icon4py variable from OS environment, not nox environment. This became necessary after the nox version was upgraded. Refer to nox PR wntrblm/nox#874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #868. Two issues:
include_outer_env=Falsedoes nothing at all ifenv=is not passed. The outer env is still included.VIRTUAL_ENV(required foruv), andCONDA_PREFIX(required for conda-family) would not be included if you do set both.Fixing this was a bit intrusive: now
.envonly is the local environmentsettings, and removals are added to it using None. The type has changed to match
.command, with the None possibility. And then the final environment is built in the_run, where it can correctly process things like adding the bin dir and filtering the None's.