Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 999 #1000

Merged
merged 2 commits into from
May 20, 2023
Merged

Fix issue 999 #1000

merged 2 commits into from
May 20, 2023

Conversation

xplants
Copy link
Contributor

@xplants xplants commented Nov 17, 2022

When a static resources, from a jar, is accessed in an environment with a custom adaptorUrl that do not start with "/cgi-bin" the wodata parameter from request is ignored and the resource is not served.

@sal-bock
Copy link

sal-bock commented Jan 11, 2023

I think you uri variable should be evaluated against request.applicationURLPrefix().
In fact, this method is used in WOResourceManager. urlForResourceNamed to generate the url. The static resources will be loaded from the jar, even if there is a proxy server is part of the game.

@paulhoadley paulhoadley self-assigned this Apr 27, 2023
@paulhoadley paulhoadley merged commit eb51c10 into wocommunity:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants