feat: middleware for agentica

[kakasoo]

This PR improves the documentation for the use method to better describe its role in registering middlewares. The updated comment clarifies execution order, next() handling, and async considerations, making it more suitable for developers using this API.

by the way, I'm still thinking about the best way to handle middleware order. What do you all think? 🤔

[sunrabbit123]

is it draft?

i think that first registered middleware should first execute

[kakasoo]

Yes, you are right. I will change its ordering.

[sunrabbit123]

please write additional test for to test after called next()

[sunrabbit123]

too

[sunrabbit123]

I recommend this "conversate" string literal convert string literal constant variable

[sunrabbit123]

I think this return value should be a Awaitable<void>
if return type is any, it means that it is being used somewhere

[sunrabbit123]

middleware should cover reqeust and response
but, current architecture can't cover response

nextjs:
https://nextjs.org/docs/app/building-your-application/routing/middleware

if user can use next(), it means cover request and response

[kakasoo]

I just added a comment about this.

[sunrabbit123]

the reason why we chose next() is because of to manage before process and after process.
however, the current middleware runs before the process.

For the previous process, we should not use the next() keyword as it confuses clients.

[sunrabbit123]

I think that this constant variable should exsits outer

[sunrabbit123]

same

[sunrabbit123]

the reason why we chose next() is because of to manage before process and after process.
however, the current middleware runs before the process.

For the previous process, we should not use the next() keyword as it confuses clients.

[sunrabbit123]

too

[kakasoo]

@sunrabbit123

{
  ...
  public async conversate(content: string): Promise<IAgenticaPrompt[]> {
    const prompt: IAgenticaPrompt.IText<"user"> = {
      type: "text",
      role: "user",
      text: content,
    };
    await this.dispatch(prompt);
    const context = this.getContext({ prompt, usage: this.token_usage_ });

    
    const newbie: IAgenticaPrompt[] = await this.executor_(context);
    this.prompt_histories_.push(prompt, ...newbie);
    const middlewares = this.middlewares_.get(CONVERSATE);
    if (middlewares) {
      await Array.from(middlewares).reduce((acc, cur) => {
        return this.middlewareCompose(acc, cur);
      })(context, async () => {});
    }
    return [prompt, ...newbie];
  }
  ...
}

Do you think should be after execute like this? @sunrabbit123

[sunrabbit123]

I think the executor should be executed innermost.

middleware should not be run twice

[kakasoo]

Like this?

[sunrabbit123]

middleware should process both before and after

so, example

const layer = this.middlewares_.get(CONVERSTAE) ?? [];
layer.push(this._executor);
const newbie = await Array.from(layer)
  .reduce((acc, cur) => this.middlewareCompose(acc, cur))(context, async () => {});

[kakasoo]

middleware should process both before and after

so, example

const layer = this.middlewares_.get(CONVERSTAE) ?? [];
layer.push(this._executor);
const newbie = await Array.from(layer)
  .reduce((acc, cur) => this.middlewareCompose(acc, cur))(context, async () => {});

I don't understand if middleware can be processed before and after execution in your code. Isn't this the act of seeing the final execution as one of the middleware and just putting execute in the end?

[kakasoo]

I've heard explanations from you. The functional form is profound. But I understand it perfectly.

[sunrabbit123]

Temporary stops