-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves error when axis is missing/incorrect attributes #481
Conversation
I'd like to revisit this in the future and refactor regrid2 to use the newer xcdat axis functions to mitigate this issue all together. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 14 28 +14
Lines 1425 2856 +1431
===========================================
+ Hits 1425 2856 +1431
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor code suggestion, then LGTM.
Co-authored-by: Tom Vo <tomvothecoder@gmail.com>
There's some weird I'll take a look at it. # >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<
Traceback (most recent call last):
File "/usr/share/miniconda3/lib/python3.10/site-packages/conda/exceptions.py", line 1124, in __call__
return func(*args, **kwargs)
File "/usr/share/miniconda3/lib/python3.10/site-packages/conda_env/cli/main.py", line 78, in do_call
exit_code = getattr(module, func_name)(args, parser)
File "/usr/share/miniconda3/lib/python3.10/site-packages/conda/notices/core.py", line 109, in wrapper
return func(*args, **kwargs)
File "/usr/share/miniconda3/lib/python3.10/site-packages/conda_env/cli/main_update.py", line 132, in execute
result[installer_type] = installer.install(prefix, specs, args, env)
File "/usr/share/miniconda3/lib/python3.10/site-packages/mamba/mamba_env.py", line 55, in mamba_install
index = load_channels(pool, channel_urls, repos, prepend=False)
File "/usr/share/miniconda3/lib/python3.10/site-packages/mamba/utils.py", line 178, in load_channels
repo = subdir.create_repo(pool)
RuntimeError: Could not read JSON repodata file (/home/runner/conda_pkgs_dir/cache/47929eba.json) parse error line 593230: subdir mismatch
`$ /usr/share/miniconda3/condabin/mamba update -n xcdat_ci -f conda-env/ci.yml` |
Nothing changed the |
Guess this restart clear it up. |
Yeah I tried restarting it a few times lol. You can merge if you are ready. |
I wonder if this improvement is going to be included for v0.6.0, which I hope so. Let me know if there is anything I can help on this PR. |
Yes this will be included in v0.6.0 since it is a simple fix. We're just waiting on @jasonb5 to merge whenever he's ready. |
Description
Improves regrid2 error when axis is missing from dataset or has incorrect attributes.
KeyError
message whencf_xarray
can't find CF attributes for coordinates withregrid2
#447Checklist
If applicable: