Exception when attempting to copy an 837 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` io.xlate.edi.stream.EDIStreamException: Invalid X12 ISA segment: too short or elements missing at io.xlate.edi.internal.stream.StaEDIStreamWriter.writeEndSegment(StaEDIStreamWriter.java:549) at io.xlate.edi.internal.stream.StaEDIStreamWriterTest.writeFromReader(StaEDIStreamWriterTest.java:757) at io.xlate.edi.internal.stream.StaEDIStreamWriterTest.testInputEquivalence(StaEDIStreamWriterTest.java:717) ```
Signed-off-by: Michael Edgar <michael@xlate.io>
|
Hi @hoffrocket , thanks for finding this. If you don't mind adding commit MikeEdgar@3835237 to your branch, I'll get that merged in and release 1.22.1. |
Ensure State is a known dialect when checking `State.isHeaderState`
|
@MikeEdgar I merged in your fix. Thanks for the amazingly fast response! |
|
Kudos, SonarCloud Quality Gate passed! |
MikeEdgar
approved these changes
Feb 13, 2023
|
Thanks again for reporting this @hoffrocket . Release 1.22.1 is available in Maven Central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to upgrade staedi from 1.17.0 to 1.22.0 and got this exception when attempting to create a copy of an 837 transaction in a manner very similar to what's happening in
StaEDIStreamWriterTest.testInputEquivalence.When I add a test case using the existing sample837 it fails with the same exception that I'm seeing:
I'm assuming this is some sort of regression? but please advise. Thanks!