Skip to content

Post 0.2.1 release chores #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Post 0.2.1 release chores #584

merged 2 commits into from
Mar 4, 2025

Conversation

mkysel
Copy link
Collaborator

@mkysel mkysel commented Mar 4, 2025

Add it as a test.

Make sure rel branches also get built in CI

Summary by CodeRabbit

  • Chores
    • Enhanced workflow configurations to automatically trigger on release branches.
  • Tests
    • Expanded upgrade testing to support version 0.2.1 with its associated container image.

@mkysel mkysel requested a review from a team as a code owner March 4, 2025 18:04
Copy link
Contributor

coderabbitai bot commented Mar 4, 2025

Walkthrough

This pull request updates three GitHub Actions workflow configurations by adding the branch pattern rel/** to the push event triggers, ensuring that pushes on release branches now trigger the workflows. Additionally, a new entry for version "0.2.1" mapping to its Docker image is added to the upgrade test map in the Go test file. No other logic or functionality changes have been introduced.

Changes

File(s) Change Summary
.github/workflows/build-xmtpd.yml, .github/workflows/solidity.yml, .github/workflows/test.yml Added branch pattern rel/** to the push event trigger to allow workflow execution on release branches.
pkg/upgrade/upgrade_test.go Added "0.2.1": "ghcr.io/xmtp/xmtpd:0.2.1" to the upgradeToLatest map for version-to-Docker image mapping.

Possibly related PRs

Suggested reviewers

  • fbac
  • richardhuaaa

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

Error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24)
Failed executing command with error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57338d0 and 661b57a.

📒 Files selected for processing (4)
  • .github/workflows/build-xmtpd.yml (1 hunks)
  • .github/workflows/solidity.yml (1 hunks)
  • .github/workflows/test.yml (1 hunks)
  • pkg/upgrade/upgrade_test.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Test (Node)
🔇 Additional comments (4)
.github/workflows/build-xmtpd.yml (1)

7-7: Added CI build support for release branches

The addition of the rel/** pattern ensures that the xmtpd Docker image build workflow triggers on pushes to release branches, which aligns with the PR objective of building release branches in CI.

pkg/upgrade/upgrade_test.go (1)

11-11: Added support for testing upgrades from v0.2.1

Good addition of version 0.2.1 to the upgrade test map, ensuring that upgrades from this version to the latest are properly tested. This aligns with the PR objective of adding tests after the 0.2.1 release.

.github/workflows/test.yml (1)

6-6: Added CI test support for release branches

The addition of the rel/** pattern ensures that the test workflow triggers on pushes to release branches, which aligns with the PR objective of ensuring release branches are tested in CI.

.github/workflows/solidity.yml (1)

7-7: Added CI Solidity support for release branches

The addition of the rel/** pattern ensures that the Solidity workflow triggers on pushes to release branches, providing consistency with the other CI workflows.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mkysel mkysel merged commit 2616b42 into main Mar 4, 2025
13 checks passed
@mkysel mkysel deleted the mkysel/0.2.1-post branch March 4, 2025 19:06
fbac pushed a commit that referenced this pull request Mar 5, 2025
Add it as a test.

Make sure rel branches also get built in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants