Skip to content

Print registrant in expected form #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Print registrant in expected form #613

merged 1 commit into from
Mar 11, 2025

Conversation

mkysel
Copy link
Collaborator

@mkysel mkysel commented Mar 11, 2025

This makes reading datadog logs much easier. The utils function dumps the string in the same format as our CLI and what we get out of the contracts.

Summary by CodeRabbit

  • Chores
    • Enhanced system logging to ensure essential operational events are captured more effectively for improved monitoring.

In this release we've updated how key system events are recorded. This improvement aids in more reliable tracking and diagnostics without affecting your overall experience or visible functionality.

@mkysel mkysel requested a review from a team as a code owner March 11, 2025 15:43
Copy link
Contributor

coderabbitai bot commented Mar 11, 2025

Walkthrough

The pull request updates the logging behavior in the NewRegistrant function. It removes a debug log statement that output the public key and adds an info-level log statement using zap.String, which leverages the utils.EcdsaPublicKeyToString function for formatting. This change updates the logging level for the public key output without modifying any exported entities.

Changes

File(s) Change Summary
pkg/registrant/registrant.go In NewRegistrant, removed the debug log statement for the public key and added an info log statement using zap.String with the public key conversion via utils.EcdsaPublicKeyToString.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

Error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24)
Failed executing command with error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20ac657 and 67631ae.

📒 Files selected for processing (1)
  • pkg/registrant/registrant.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Test (Node)
  • GitHub Check: Build pre-baked anvil-xmtpd
🔇 Additional comments (1)
pkg/registrant/registrant.go (1)

58-58: Improved logging format for public key - great change!

This change enhances the readability of Datadog logs by including the public key in a readable string format at the info log level. Moving this from debug level (as noted in the summary) to info level and using utils.EcdsaPublicKeyToString() for proper formatting will make it easier to identify and track registrants in logs.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mkysel mkysel merged commit 2488753 into main Mar 11, 2025
6 of 7 checks passed
@mkysel mkysel deleted the mkysel/prints branch March 11, 2025 16:07
mkysel added a commit that referenced this pull request Mar 20, 2025
This makes reading datadog logs much easier. The utils function dumps
the string in the same format as our CLI and what we get out of the
contracts.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Enhanced system logging to ensure essential operational events are
captured more effectively for improved monitoring.

In this release we've updated how key system events are recorded. This
improvement aids in more reliable tracking and diagnostics without
affecting your overall experience or visible functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants