Fix leading and the definition&documentation of \thesis@xpatch #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Witiko
force-pushed
the
feature/fix-leading
branch
4 times, most recently
from
ceaff11 to
fdaef2a
Compare
Fix spacing in \thesis@xpatch calls
Witiko
force-pushed
the
feature/fix-leading
branch
from
fdaef2a to
79d4344
Compare
Witiko
changed the title
Witiko
changed the title
|
As a side change, I added the missing third argument to
|
Witiko
force-pushed
the
feature/fix-leading
branch
from
94b6f3b to
2f0ec43
Compare
Witiko
force-pushed
the
feature/fix-leading
branch
from
2f0ec43 to
4abf8e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title text has insufficient leading as shown in #42 (bottom right). This is caused by the following:
{\sf\thesis@titlePage@large\thesis@@upper{facultyName}}\par % Incorrect, will reset to original font before \par. {\sf\thesis@titlePage@large\thesis@@upper{facultyName}\par}% % Correct, will only reset to original font after \par.This pull request exhaustively fixes all instances of this error in all definitions, redefinitions, and xpatches of
\thesis@blocks@titlePageand\thesis@blocks@cover. See below for a before-and-after comparison of the title page of FI:Additionally, this PR changes the
\thesis@blocks@coverredefinition for ECON to a\thesis@xpatch, so that I get to play with it. 😄