Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove old style mu logo #49

Merged
merged 6 commits into from
Jul 18, 2021
Merged

Feature/remove old style mu logo #49

merged 6 commits into from
Jul 18, 2021
+99 −4,796

Conversation

Witiko
Copy link
Collaborator

@Witiko Witiko commented Jul 17, 2021

Closes #48:

fig-1 1

fig-3 1

fig-3 2

Witiko added 6 commits May 25, 2021 14:28
@Witiko
Symlink Slovak logos to avoid duplicate files

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Witiko Vít Starý Novotný
GPG key ID: C96C14BAB072F4B0
Expired
Verified
Learn about vigilant mode
8f2156d
@Witiko
Merge remote-tracking branch 'xvrabcov/master' into feature/remove-ol…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Witiko Vít Starý Novotný
GPG key ID: C96C14BAB072F4B0
Expired
Verified
Learn about vigilant mode
8a93d73 
…d-style-mu-logo
@Witiko
Replace old-style MU logo with JVS MU logo and faculty seals in examples

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Witiko Vít Starý Novotný
GPG key ID: C96C14BAB072F4B0
Expired
Verified
Learn about vigilant mode
5202e64
@Witiko
Add proper handling of VERSION.tex file in Makefile

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Witiko Vít Starý Novotný
GPG key ID: C96C14BAB072F4B0
Expired
Verified
Learn about vigilant mode
7184457
@Witiko
Load fithesis-mu-1*.clo size option, not fithesis-1*.clo

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Witiko Vít Starý Novotný
GPG key ID: C96C14BAB072F4B0
Expired
Verified
Learn about vigilant mode
8be80a3
@Witiko
Resize MU logo in examples

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Witiko Vít Starý Novotný
GPG key ID: C96C14BAB072F4B0
Expired
Verified
Learn about vigilant mode
c562cef
@Witiko Witiko requested a review from xvrabcov July 18, 2021 09:47
@Witiko Witiko mentioned this pull request Jul 18, 2021
Merged
xvrabcov
xvrabcov approved these changes Jul 18, 2021
View reviewed changes
Copy link
Owner

@xvrabcov xvrabcov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, especially the refactoring :). Do I understand it correctly that the university logo (the example of \includegraphics) will be in english, regardless of the main language settings?

@Witiko
Copy link
Collaborator Author

Witiko commented Jul 18, 2021

Seems good, especially the refactoring :). Do I understand it correctly that the university logo (the example of \includegraphics) will be in english, regardless of the main language settings?

Yes. Also, the logo will be in color regardless of the color settings. We could add some conditionals around, or use TeX commands from the private API of fithesis, but I think the main purpose of the example code is to be legible.

@Witiko Witiko mentioned this pull request Jul 18, 2021
Merged
@Witiko Witiko merged commit 0ab322a into xvrabcov:master Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xvrabcov xvrabcov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the old-style MU logo in the example documents
2 participants
@Witiko @xvrabcov