remove reverend in favor of path-to-regexp.compile

[jasisk]

Path-to-regexp, which powers Reverend, has recently added the ability to reverse routes, rendering Reverend unnecessary. As such, Reverend is in the process of being deprecated.

The sole differences between the implementation in Reverend and that of path-to-regexp is a bit of duck-typing to prevent throws. This small amount of duck-typing can be seen in the shim branch.

I've duplicated the logic from Reverend here however, if it is unnecessary, it can be removed to simplify the code.

[yahoocla]

CLA is valid!

[jasisk]

Adding a test for coverage.

[coveralls]

Coverage remained the same at 100.0% when pulling 8a831b0 on jasisk:remove-reverend into 9090dd3 on yahoo:master.

[mridgway]

Wow, thanks so much for updating your dependents! We'll get this merged in ASAP.

@lingyan Want to take a look?

[jasisk]

Happy to.

As mentioned, I codified the existing behavior but it's just a carryover from a legacy path-to-regexp. I don't think it necessarily makes sense but I wanted to capture it and leave that decision up to you fine folks. 😀

[jasisk]

One difference worth mentioning:
path-to-regexp accounts for trailing slash cases that we never did (though we had an issue filed against it).
The impacted cases can be seen in the tests from the shim branch.

[mridgway]

Absolutely, makes sense. We'll take it from here and decide which parts we need or don't need.

[lingyan]

@jasisk This is awesome. Thanks a lot for the PR. There is some minor changes we can make. I will merge the PR and we can take it from here. Thanks again!

[lingyan]

@jasisk FYI, new patch version released with your contribution: https://github.com/yahoo/routr/releases/tag/v0.1.2 Thanks!

[jasisk]

My pleasure. It's always frustrating when something goes away quietly. Figured I'd help alleviate some of that frustration. Plus you all do excellent work—happy to make a minuscule contribution to it.