-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove reverend in favor of path-to-regexp.compile #23
Conversation
CLA is valid! |
Adding a test for coverage. |
Wow, thanks so much for updating your dependents! We'll get this merged in ASAP. @lingyan Want to take a look? |
Happy to. As mentioned, I codified the existing behavior but it's just a carryover from a legacy |
One difference worth mentioning: |
Absolutely, makes sense. We'll take it from here and decide which parts we need or don't need. |
@jasisk This is awesome. Thanks a lot for the PR. There is some minor changes we can make. I will merge the PR and we can take it from here. Thanks again! |
remove reverend in favor of path-to-regexp.compile
@jasisk FYI, new patch version released with your contribution: https://github.com/yahoo/routr/releases/tag/v0.1.2 Thanks! |
My pleasure. It's always frustrating when something goes away quietly. Figured I'd help alleviate some of that frustration. Plus you all do excellent work—happy to make a minuscule contribution to it. |
Path-to-regexp, which powers Reverend, has recently added the ability to reverse routes, rendering
Reverend
unnecessary. As such,Reverend
is in the process of being deprecated.The sole differences between the implementation in
Reverend
and that ofpath-to-regexp
is a bit of duck-typing to prevent throws. This small amount of duck-typing can be seen in the shim branch.I've duplicated the logic from
Reverend
here however, if it is unnecessary, it can be removed to simplify the code.