Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use guest identity instead of nulls #73

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use guest identity instead of nulls #73

wants to merge 2 commits into from

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Apr 7, 2023

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ✔️

@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (427a5ab) 88.44% compared to head (47713d9) 88.36%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     88.44%   88.36%   -0.09%     
+ Complexity       95       93       -2     
============================================
  Files            13       13              
  Lines           277      275       -2     
============================================
- Hits            245      243       -2     
  Misses           32       32
Impacted Files Coverage Δ
src/CurrentUser.php 100.00% <100.00%> (ø)
src/UserAuth.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark
Copy link
Member

samdark commented Jun 30, 2023

Overall the change looks OK. Need a CHANGELOG for it.

Also, it's is backwards compatibility breaking one.

vjik
vjik requested changes Jul 1, 2023
View reviewed changes
src/UserAuth.php
Comment on lines -31 to -34
if ($this->currentUser->isGuest()) {
return null;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's break logic of Yii Auth package in Authentication middleware: https://github.com/yiisoft/auth/blob/27a4e9ac4e89d810625c73f1578586d2ecdc9c27/src/Middleware/Authentication.php#L48C43-L48C53

@xepozz xepozz marked this pull request as draft July 1, 2023 13:41
@xepozz
Copy link
Member Author

xepozz commented Jul 1, 2023

It shouldn't be merged yet because it cause bugs in authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik requested changes

@rustamwin rustamwin rustamwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xepozz @samdark @vjik @rustamwin