Skip to content

Used new enum for template names from Anatomy #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Mar 31, 2025

Changelog Description

There was a new anatomy_template_items_enum added to server backend which provides dropdown instead of manually providing text value which could cause issues of wrong format/typos.

anatomy_template_items_enum could be used with selected template type as publish|render or without it. In case of without preselection template name is concatenated in format tempateType_templateName (eg. publish_default) as each template type contains at least same default value.

Additional info

This PR depends on ynput/ayon-backend#558 and should be merged ONLY after new release of server. (And bumping ayon server dependency in package.py)

Defaults contain tycache values which are not part of Anatomy. These defaults should be probably removed.

Testing notes:

  1. use ayon-backend PR for your server
  2. install package for ayon-core
  3. check ayon+settings://core/tools/publish/template_name_profiles

@kalisp kalisp added the type: enhancement Improvement of existing functionality or minor addition label Mar 31, 2025
@kalisp kalisp self-assigned this Mar 31, 2025
@ynbot ynbot added the size/XS label Mar 31, 2025
@kalisp kalisp marked this pull request as draft March 31, 2025 13:02
Copy link

@MilaKudr MilaKudr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its there
Screenshot 2025-03-31 152834

@iLLiCiTiT
Copy link
Member

This PR should bump required server version.

@ynbot ynbot moved this to Review In Progress in PR reviewing Apr 1, 2025
@kalisp kalisp marked this pull request as ready for review April 1, 2025 10:04
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Apr 1, 2025

Ok, so this PR is created at a time the enumerators are even not yet in any ayon-backend release. I think we should wait for some time with merging this.

@kalisp kalisp requested review from MilaKudr and iLLiCiTiT April 1, 2025 10:25
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this should be merged after ayon-backend#558, but tests were working as expected so it is approval from me ;)

@github-project-automation github-project-automation bot moved this from Review In Progress to Merge Requested in PR reviewing Apr 1, 2025
@kalisp
Copy link
Member Author

kalisp commented Apr 11, 2025

This could get merged theoretically, correct? I bumped server dependency to >=1.7.6 (first version of server with enum)

@iLLiCiTiT
Copy link
Member

This could get merged theoretically, correct? I bumped server dependency to >=1.7.6 (first version of server with enum)

Can this wait a week? 1.7.6 was released last week and this is not must have PR (at least it doesn't look like it is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
Status: Merge Requested
Development

Successfully merging this pull request may close these issues.

5 participants