-
Notifications
You must be signed in to change notification settings - Fork 46
Used new enum for template names from Anatomy #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should bump required server version. |
Ok, so this PR is created at a time the enumerators are even not yet in any ayon-backend release. I think we should wait for some time with merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that this should be merged after ayon-backend#558, but tests were working as expected so it is approval from me ;)
…ancement/anatomy_template_enum
…ancement/anatomy_template_enum
This could get merged theoretically, correct? I bumped server dependency to >=1.7.6 (first version of server with enum) |
Can this wait a week? 1.7.6 was released last week and this is not must have PR (at least it doesn't look like it is). |
Changelog Description
There was a new
anatomy_template_items_enum
added to server backend which provides dropdown instead of manually providing text value which could cause issues of wrong format/typos.anatomy_template_items_enum
could be used with selected template type aspublish
|render
or without it. In case of without preselection template name is concatenated in formattempateType_templateName
(eg.publish_default
) as each template type contains at least samedefault
value.Additional info
This PR depends on ynput/ayon-backend#558 and should be merged ONLY after new release of server. (And bumping ayon server dependency in
package.py
)Defaults contain
tycache
values which are not part ofAnatomy
. These defaults should be probably removed.Testing notes:
ayon-backend
PR for your serverayon+settings://core/tools/publish/template_name_profiles