Remove ArrayV2 #1857
Merged
Remove ArrayV2 #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanrz
changed the title
d-v-b
reviewed
May 9, 2024
d-v-b
reviewed
May 9, 2024
d-v-b
reviewed
May 9, 2024
d-v-b
reviewed
May 9, 2024
d-v-b
reviewed
May 9, 2024
Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com>
6 tasks
jhamman
approved these changes
May 14, 2024
6 tasks
Co-authored-by: Joe Hamman <joe@earthmover.io>
…on into v3-v2-pipeline
|
This PR depends on #1670. I'll leave this one open until the other is ready. |
normanrz
added a commit
that referenced
this pull request
May 17, 2024
* merge * refactors CodecPipelines * fixes * adds HybridCodecPipeline * fixes * typing * typing * consistent naming * Apply suggestions from code review Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com> * encode/decode are batched by default * use zarr.config for batch_size * don't use global lru_cache * removes HybridCodecPipeline * generic codec classes * default batch size = 1 * default batch size = 1 * docs * Update src/zarr/codecs/batched_codec_pipeline.py Co-authored-by: Joe Hamman <joe@earthmover.io> * mv batched_codec_pipeline -> pipeline * Remove ArrayV2 (#1857) * adds wrapper codecs for the v2 codec pipeline * encode_chunk_key * refactor ArrayV2 away * empty zattrs * Apply suggestions from code review Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com> * unify ArrayMetadata * abstract ArrayMetadata * unified Array.create * use zarr.config for batch_size * __init__.py aktualisieren Co-authored-by: Joe Hamman <joe@earthmover.io> * ruff --------- Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com> Co-authored-by: Joe Hamman <joe@earthmover.io> * merge --------- Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com> Co-authored-by: Joe Hamman <joe@earthmover.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ArrayV2class. TheArrayclass can now take either aArrayMetadataorArrayV2Metadataobject and perform create, open and save accordingly.Note, there is still a separate
create_v2method. We might want to merge that into thecreatemethod.The V2 codec pipeline is implemented with the new
V2CompressorandV2Filterscodecs. They act as wrappers around the compressor and filters of zarr v2.I also did some light refactorings in the Group to unify with the Array.
cc @jhamman
TODO: