Skip to content

Fix sqlite store in 2.x #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Mar 3, 2025

This is a minimal attempt to fix the failing sqlite tests on the 2.x branch

@dstansby dstansby marked this pull request as draft March 3, 2025 12:55
@dstansby dstansby marked this pull request as ready for review March 3, 2025 13:10
@dstansby dstansby added the V2 Affects the v2 branch label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (2bf7e45) to head (7498427).
Report is 2 commits behind head on support/v2.

Additional details and impacted files
@@             Coverage Diff             @@
##           support/v2    #2880   +/-   ##
===========================================
  Coverage       99.95%   99.95%           
===========================================
  Files              38       38           
  Lines           14672    14680    +8     
===========================================
+ Hits            14666    14674    +8     
  Misses              6        6           
Files with missing lines Coverage Δ
zarr/_storage/v3.py 100.00% <100.00%> (ø)
zarr/storage.py 99.77% <100.00%> (ø)

@dstansby dstansby changed the title (try to) fix sqlite store in 2.x Fix sqlite store in 2.x Mar 3, 2025
@d-v-b d-v-b merged commit 153deff into zarr-developers:support/v2 Mar 3, 2025
16 checks passed
@dstansby dstansby deleted the fix-sqlite branch March 3, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Affects the v2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants