Fix AsyncGroup.create_dataset() dtype handling and optimize tests #3050 #3059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3050
AsyncGroup.create_dataset()
:-- If
dtype
is not provided in the arguments-- And
if data is None
(meaning no data is being provided to infer the dtype from)-- Then raise a clear error message saying "
dtype
must be provided ifdata is None
"create_array()
always receives the requireddtype
parameter, preventing potential errors downstreamtest_properties.py
:-- Removed the time limit by setting
deadline=None
and suppressing the"too slow"
health check-- Reduced the complexity of test cases by:
-- Limiting arrays to maximum 3 dimensions (down from 4)
-- Setting maximum side length to 8 (to prevent very large arrays)
-- Adding assumptions to prevent repeated indices in test cases
-- For test_vindex, limiting the result shape to 2 dimensions to reduce complexity
Please let me know if there is any changes needed to the approach in the tests or the issue fix.
TODO:
docs/user-guide/*.rst
changes/