Skip to content

Fixes #649 #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2020
Merged

Fixes #649 #650

merged 2 commits into from
Nov 18, 2020

Conversation

martindurant
Copy link
Member

@martindurant martindurant commented Nov 11, 2020 •
edited
Loading

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

@codecov
Copy link

codecov bot commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #650 (e2811ca) into master (06450d0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #650   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines        10066     10068    +2     
=========================================
+ Hits         10066     10068    +2
Impacted Files Coverage Δ
zarr/convenience.py 100.00% <100.00%> (ø)
zarr/core.py 100.00% <100.00%> (ø)
zarr/storage.py 100.00% <100.00%> (ø)
zarr/tests/test_storage.py 100.00% <100.00%> (ø)

rabernat
rabernat reviewed Nov 11, 2020
View reviewed changes
Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm finding the call sequence a bit hard to follow here.

@AliceBalfanz AliceBalfanz mentioned this pull request Nov 18, 2020
Merged
7 tasks
@martindurant martindurant removed the request for review from rabernat November 18, 2020 17:24
@jakirkham jakirkham requested a review from rabernat November 18, 2020 18:32
@jakirkham
Copy link
Member

@rabernat, would you have time to take another look? No worries if not 🙂

rabernat
rabernat approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @martindurant!

@martindurant
Copy link
Member Author

Merging as this already passed CI earlier, but didn't start a new build for some reason (there were no code changes).

@martindurant martindurant merged commit c0358a9 into zarr-developers:master Nov 18, 2020
@martindurant martindurant deleted the small_storage_fixes branch November 18, 2020 21:50
@Carreau Carreau added this to the v2.6 milestone Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau approved these changes

@rabernat rabernat rabernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.
4 participants
@martindurant @jakirkham @Carreau @rabernat