Refactor and add unit tests for rest and label calibration #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #40
Background info:
# any relevant background info for additional context, references to documentations etc.
load_model()
method insidequalle/interface/rest.py
has no corresponding unit test. A new unit test should be included.else
statement inside theget_concepts_for_subthesaurus()
method found inqualle/features/label_calibration/thesauri_label_calibration.py
is not being considered in our existing unit tests. This should be remedied.qualle
the version and release-date were not updated inside thepyproject.toml
file andCITATION.cff
files. This info should be updated.Changes introduced:
# list changes to the code repo made in this pull request
load_model()
.test_get_concepts_for_thesaurus()
found intests/features/label_calibration/test_thesauri_label_calibration.py
. Some additions had to be introduced inside thecommon.py
andconftest.py
files located in the very same folder.qualle
have been updated to match the most recent release. The values insidepyproject.toml
file andCITATION.cff
file were bumped.pytest
filter warnings decorator has been added to filterRuntimeWarning
associated with two unit tests that are deliberately usingnan
values. This point was also mentioned in pull request Warnings being raised in the unit tests #31 .