Fix race condition on nodes table revalidation #69
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a reported race condition affecting nodes table revalidation by introducing a new read/write mutex (ntLock) to protect access to the revalidationList's nextTime and nodes.
- Added a new RWMutex (ntLock) within the revalidationList struct.
- Updated the critical sections in the run, schedule, and remove functions to use the new lock for proper synchronization.
Comments suppressed due to low confidence (1)
portalwire/table_reval.go:251
- [nitpick] In the remove function, the use of a write lock when updating nextTime is appropriate; please verify that all modifications related to nextTime throughout the file are consistently protected by ntLock.
list.ntLock.Lock()
|
@fearlessfe what is your change compare with this PR? |
|
Thanks @r4f4ss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #61 only on
table_reval.goI was not able to reproduce the race condition on
portal_protocol.goand the file was modified since the issue report.