Improve mt9m114 camera driver #70237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decsny
reviewed
Mar 15, 2024
|
Hi @loicpoulain , |
loicpoulain
reviewed
Mar 20, 2024
Run clang format before making any changes Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
Drop unused register macros and coherently use major letters for register address. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
Currently, the driver supports only VGA resolution while 480x272 is needed to match with the display resolution on i.MX RT10XX family. Also, the current framerate is very low, about 3-4 fps without doing anything else with the image buffers (just discarding them). Rework the driver to address the low framerate issue as well as to add support for 480x272 and 1280x720 resolutions. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
|
@loicpoulain @decsny Thanks ! Issues were addressed with the new updates. |
|
Hi @loicpoulain , is it ok for you now ? |
loicpoulain
approved these changes
Mar 26, 2024
|
Hi @decsny , could you help to review and / or approve this so that it can be merged ? |
decsny
approved these changes
Mar 26, 2024
dleach02
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the driver supports only VGA resolution while 480x272 is needed to match with the display resolution on i.MX RT10XX family.
Also, the current framerate is very low, about 3-4 fps without doing anything else with the image buffers (just discarding them).
This PR reworks the driver to address the low framerate issue as well as to add support for 480x272 and 1280x720 resolutions.