Enable STM32L4R9i-disco DSI display via shield ST_B_DSI_MB1314 #86812
+503
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 8, 2025 22:15
Add support for the GVO G1120TB101 DSI Panel. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Rely on the pixel format defined within the display node in order to configure the DSI interface pixel format. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Use the macro DISPLAY_BITS_PER_PIXEL in order to compute each format BPP and thus avoid requiring each format BPP written within the driver. Thanks to that, simply the function stm32_ltdc_set_pixel_format to avoid code duplication. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Addition of the STM32_SRC_HSE define in stm32l4_clock.h in order to be able to address the HSE clock source from the device-tree. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
stm32l4r9 series embeds a MIPI DSI controller which uses the LTDC controller as input. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
ltdc controller is also available in stm32l4r5 and stm32l4q5 so add it within stm32l4p5. It is not available in stm32l4r5 hence delete the node for this platform. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Add a zephyr_mipi_dsi alias for the mipi_dsi so that shields can refer to it to add panels on this interface. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Addition of a new shield which embeds a round DSI display gvo,g1120tb101 of 390x390 pixels, with a touchpanel. This shield enables it via usage of the LTDC and DSI of the STM32. Touchpanel isn't yet supported in this commit and will be added later on in an additional commit. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
zephyrbot
added
area: MIPI-DSI
area: Clock Control
area: Shields
zephyrbot
requested review from
avisconti,
danieldegrasse,
decsny,
djiatsaf-st,
erwango,
FRASTM,
galak,
gautierg-st,
GeorgeCGV,
jfischer-no,
kartben,
marwaiehm-st,
mathieuchopstm,
mbolivar and
rruuaanng
JarmouniA
suggested changes
Mar 8, 2025
There was a problem hiding this comment.
Board specific options should be moved to a board specific conf file, similar to https://github.com/zephyrproject-rtos/zephyr/tree/main/boards/shields/st_b_lcd40_dsi1_mb1166/boards
There was a problem hiding this comment.
Board specific nodes/props should be moved to a board specific overlay, similar to https://github.com/zephyrproject-rtos/zephyr/tree/main/boards/shields/st_b_lcd40_dsi1_mb1166/boards
| @@ -0,0 +1,20 @@ | |||
| # Copyright (c) 2025 ST Microelectronics | |||
There was a problem hiding this comment.
Nit: STMicroelectronics (same for other files)
| depends on DT_HAS_GVO_G1120TB101_ENABLED | ||
| select MIPI_DSI | ||
| help | ||
| Enable driver for GVO G1120TB101 display driver. |
There was a problem hiding this comment.
Suggested change
| Enable driver for GVO G1120TB101 display driver. | |
| Enable driver for GVO G1120TB101 display controller. |
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config G1120TB101 | ||
| bool "G1120TB101 display driver" |
There was a problem hiding this comment.
Suggested change
| bool "G1120TB101 display driver" | |
| bool "G1120TB101 display controller" |
| } else if (format == PIXEL_FORMAT_ARGB_8888) { | ||
| ltdc_pix_fmt = LTDC_PIXEL_FORMAT_ARGB8888; | ||
| } else { | ||
| return -ENOTSUP; |
| @@ -0,0 +1,273 @@ | |||
| /* | |||
| * Copyright (c) 2025 ST Microelectronics | |||
| * Inpired from display_otm8009a.c | |||
There was a problem hiding this comment.
Typo:
Suggested change
| * Inpired from display_otm8009a.c | |
| * Inspired from display_otm8009a.c |
Comment on lines
+59
to
+60
| #define STM32_LTDC_INIT_PIXEL_SIZE DISPLAY_BITS_PER_PIXEL(DISPLAY_INIT_PIXEL_FORMAT) /\ | ||
| BITS_PER_BYTE |
There was a problem hiding this comment.
I think this might be more readable if the / is on the second line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates, new driver and a new shield in order to enable the DSI display that can be mounted on the STM32L4R9I-DISCO board.
It enables both LTDC and DSI interfaces of the STM32L4R9 and for that purpose require the usage of the PLLSAI.
PLLSAI support isn't yet merged. There is another ongoing pull request for that purpose which can be found here:
#85135
The PLLSAI pull-request is still evolving hence this new pull-request will be rebased afterward once the PLLSAI will be merged.
Since it rely on another pull-request, it won't build (missing pllsai nodes or macros) but I am already pushing this one in order to start the review process.