Skip to content

feat: Add force flag for connect requests #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2021
Merged

feat: Add force flag for connect requests #91

merged 5 commits into from
Nov 8, 2021

Conversation

skarahoda
Copy link

Change description

With Zeplin Storybook integration, users can update the connected component data from web and desktop apps. Using both CLI and web/desktop apps can be confusing for users. That's why we forbid updating the data from CLI if it's updated from web or desktop apps. To override this restriction, we also add force flag. So users can continue to use CLI even if they mistakenly update configuration from web or desktop apps.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@skarahoda skarahoda self-assigned this Nov 4, 2021
@skarahoda skarahoda requested review from yuqu and yuksely November 4, 2021 15:24
yuqu
yuqu reviewed Nov 5, 2021
View reviewed changes
@skarahoda skarahoda requested a review from yuqu November 5, 2021 09:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@skarahoda skarahoda merged commit 4f7f5da into main Nov 8, 2021
@skarahoda skarahoda deleted the feature/force branch November 8, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqu yuqu yuqu approved these changes

@burakaraz burakaraz Awaiting requested review from burakaraz

@aykutbulca aykutbulca Awaiting requested review from aykutbulca

@okan-cakmak okan-cakmak Awaiting requested review from okan-cakmak

@yuksely yuksely Awaiting requested review from yuksely

Assignees

@skarahoda skarahoda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skarahoda @yuqu