Skip to content

Improve Cache implementation #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2023
Merged

Improve Cache implementation #2902

merged 1 commit into from
Oct 2, 2023

Conversation

guizmaii
Copy link
Member

  • Reduce pressure on GC by using a mutable Map
  • Compute now only once

Found this thanks to research done in #2886

@guizmaii
Improve Cache implementation:
4db8ac2 
- Reduce pressure on GC by using a mutable Map
- Compute `now` only once
@guizmaii guizmaii mentioned this pull request Sep 30, 2023
Closed
juliano
juliano approved these changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@juliano juliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guizmaii guizmaii merged commit 7347704 into master Oct 2, 2023
@guizmaii guizmaii deleted the clean_5 branch October 2, 2023 05:30
jilen pushed a commit that referenced this pull request Jun 11, 2024
@guizmaii
Improve Cache implementation: (#2902)
4433cce 
- Reduce pressure on GC by using a mutable Map
- Compute `now` only once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliano juliano juliano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guizmaii @juliano