Skip to content

just some fun with the console #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

just some fun with the console #728

wants to merge 3 commits into from

Conversation

mosch
Copy link
Contributor

@mosch mosch commented Feb 21, 2025

No description provided.

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zudoku-cosmo-cargo ✅ Ready (Inspect) Visit Preview Apr 10, 2025 3:01pm
zudoku-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 3:01pm
zudoku-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 3:01pm

Copy link

nx-cloud bot commented Feb 21, 2025

View your CI Pipeline Execution ↗ for commit 063e3a6.

Command Status Duration Result
nx run-many -t lint:ci format:ci build:ci test ❌ Failed 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-10 15:01:55 UTC

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a styled console log message to display the application name and version info when the client entry point is executed.

  • Adds a console log with custom CSS styling.
  • Inserts a debug message as a fun visual element in the client entry file.

Reviewed Changes

File Description
packages/zudoku/src/app/entry.client.tsx Adds a styled console.log message

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/zudoku/src/app/entry.client.tsx:52

  • [nitpick] The hex color code '#Df0097' appears to have inconsistent capitalization. For clarity and consistency, consider using '#DF0097'.
"color: #Df0097",

"text-transform: uppercase",
"text-align: center",
"letter-spacing: 5px",
].join(" ;"),
Copy link
Preview

Copilot AI Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The use of join(" ;") may introduce unintended white space into the CSS styling. Consider using join(';') to ensure the styles are applied correctly.

Suggested change
].join(" ;"),
].join(';'),

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think join("; ") would be more appropriate?

@ntotten
Copy link
Member

ntotten commented Mar 6, 2025

What about making it say "Powered by Zudoku. Built by Zuplo." or similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Will not appear in generated release notes
Development

Successfully merging this pull request may close these issues.

3 participants