Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmd input parameter check #137

Merged
merged 6 commits into from
Jun 13, 2019
Merged

Cmd input parameter check #137

merged 6 commits into from
Jun 13, 2019

Conversation

jllucas
Copy link

@jllucas jllucas commented Jun 13, 2019

Check cmd URL params. There are 2 types:

  • schema+host+[port]: endpoint addresses
  • host+[port]: binding addresses

Jose Luis Lucas added 3 commits June 12, 2019 15:12
Feat: Add checks to cmd URL parameters.
348a721
Feat: Add server checks.
4c74af2 
Feat: Transform urlParse and urlParseNoSchemaRequired functions into variadics.

Closes BBVA#89
Feat: Improve error messages
3ca708d
@jllucas jllucas requested a review from iknite June 13, 2019 10:05
iknite
iknite approved these changes Jun 13, 2019
View reviewed changes
@jllucas jllucas merged commit 6653e3e into BBVA:master Jun 13, 2019
@jllucas jllucas deleted the checkparams branch June 13, 2019 12:44
suizman pushed a commit that referenced this pull request Sep 30, 2019
Merge pull request #137 from jllucas/checkparams
328ce96 
Cmd input parameter check 

Former-commit-id: 6653e3e
suizman pushed a commit that referenced this pull request Sep 30, 2019
Merge pull request #137 from jllucas/checkparams
9c956a0 
Cmd input parameter check 

Former-commit-id: ee6e836 [formerly 6653e3e]
Former-commit-id: 328ce96
suizman pushed a commit that referenced this pull request Sep 30, 2019
Merge pull request #137 from jllucas/checkparams
ee6e836 
Cmd input parameter check 

Former-commit-id: 6653e3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iknite iknite iknite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jllucas @iknite