Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tbolt/4349 Remove AJV Validation #4389

Merged
merged 131 commits into from
Nov 10, 2022
Merged

Tbolt/4349 Remove AJV Validation #4389

merged 131 commits into from
Nov 10, 2022

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Nov 2, 2022

Resolves #4349

Description

This PR removes the AJV validation as it is no longer needed.

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@tbolt tbolt added the feature PR label for release log label Nov 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #4389 (0fcca32) into main (a256f6d) will decrease coverage by 0.59%.
The diff coverage is 88.26%.

❗ Current head 0fcca32 differs from pull request most recent head a64c38a. Consider uploading reports for the commit a64c38a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4389      +/-   ##
==========================================
- Coverage   85.98%   85.39%   -0.60%     
==========================================
  Files         263      265       +2     
  Lines        6038     6163     +125     
  Branches     1287     1321      +34     
==========================================
+ Hits         5192     5263      +71     
- Misses        783      837      +54     
  Partials       63       63              
Impacted Files Coverage Δ
web/src/components/Icons.js 80.00% <ø> (ø)
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)
...ies/cost-allocation/CostAllocation/CostAllocate.js 86.36% <ø> (ø)
...w/NameAndFundingSource/NameAndFundingSourceForm.js 59.25% <ø> (ø)
web/src/pages/apd/activities/overview/Overview.js 87.50% <ø> (ø)
web/src/pages/apd/activities/overview/Schedule.js 56.66% <0.00%> (-2.71%) ⬇️
.../apd/activities/overview/StandardsAndConditions.js 78.26% <ø> (ø)
...y-state-personnel/ApdStateProfileMedicaidOffice.js 38.59% <ø> (ø)
...src/pages/apd/proposed-budget/IncentivePayments.js 71.18% <ø> (ø)
web/src/redux/reducers/nav.js 91.66% <0.00%> (ø)
... and 25 more

Impacted file tree graph

Impacted Files Coverage Δ
web/src/components/Icons.js 80.00% <ø> (ø)
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)
...ies/cost-allocation/CostAllocation/CostAllocate.js 86.36% <ø> (ø)
...w/NameAndFundingSource/NameAndFundingSourceForm.js 59.25% <ø> (ø)
web/src/pages/apd/activities/overview/Overview.js 87.50% <ø> (ø)
web/src/pages/apd/activities/overview/Schedule.js 56.66% <0.00%> (-2.71%) ⬇️
.../apd/activities/overview/StandardsAndConditions.js 78.26% <ø> (ø)
...y-state-personnel/ApdStateProfileMedicaidOffice.js 38.59% <ø> (ø)
...src/pages/apd/proposed-budget/IncentivePayments.js 71.18% <ø> (ø)
web/src/redux/reducers/nav.js 91.66% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f95ed8...a64c38a. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Nov 3, 2022

See this pull request in action: https://ec2-18-206-77-240.compute-1.amazonaws.com

a64c38a

@tbolt tbolt requested review from thetif and Sun-Mountain November 3, 2022 16:56
Base automatically changed from tbolt/3676-admin-check-drawer to main November 4, 2022 14:00
Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @jeromeleecms ready for your review. Nothing was added in this PR, just cleanup.

@tbolt tbolt requested a review from jeromeleecms November 9, 2022 20:06
@tbolt tbolt merged commit 4c659cd into main Nov 10, 2022
@tbolt tbolt deleted the tbolt/4349-remove-ajv branch November 10, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Remove AJV Validation
5 participants