-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing .lnk files for TeXworks #10977
Comments
I am Interested in contributing to this Issue. |
As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at. Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback. |
What does getSpi Method do in WindowsPreferences.java |
I don't find this class in JabRef. Do you have a link? |
@Jayachandra5 This is far away from this issue. You can submit a question at https://discourse.jabref.org/c/programming/44. Some words: Users can configure JabRef. What are the defaults if nothing is configured? The ones in the HashMap. Where are the configurations stored? In Windows registry. How to access? Using Java properties? How named in JabRef? "Preferences"? |
Hello! I want to fix this issue. I have a question: do I need to add any test for this bugfix? |
@InAnYan I did not see any activity by @Jayachandra5 , thus I re- assign to you. Tests are always good. Just give it a thought. Maybe with jimfs (https://github.com/google/jimfs), but could be too much effort... |
* Added support for parsing .lnk files for TeXworks (#10977) * Revert "Added support for parsing .lnk files for TeXworks (#10977)" This reverts commit f3e2df3. * Added support for parsing .lnk files for TeXworks (#10977) * Added support for parsing .lnk files for TeXworks (#10977) * Resolved CheckStyle errors * Introduce getEmptyIsDefault * Compilefix * Update build.gradle and changed empty catch branch * Used another logger --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
(Follow-up to #10953)
JabRef currently, doesn't find TeXWorks when MiKTeX is installed on Windows.
In the prefs we have some autodetect logic
jabref/src/main/java/org/jabref/preferences/JabRefPreferences.java
Line 545 in 94928dd
On my machine, the app can be found via the following steps:
%APPDATA%\Microsoft\Windows\Start Menu\Programs\MiKTeX\TeXworks.lnk
Target
from it. On my machine:C:\MiKTeX\miktex\bin\x64\miktex-texworks.exe
Use the mslinks library for parsing the lnk file. The implementation should be implemented in
org.jabref.gui.desktop.os.Windows#detectProgramPath
.Alternative:
However, when I click Save in the preferences, there should be a check. If the binary could not be found, user should be asked to navigate to the options.
The text was updated successfully, but these errors were encountered: