-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .lnk files for TeXworks #11065
Conversation
This reverts commit f3e2df3.
Hmm, I see there 3 failed checks. But, |
You can ingore the unrelated tests |
Users need to reset their preferences to get this working. Reason: applicationCommands.put(PushToApplications.TEXWORKS, get(PUSH_TEXWORKS_PATH)); returns Therefore, I introduced a Tried out locally, works. |
Hello! I've checked all the review comments and did this:
I probably should have mentioned it before, but I have MiKTeX on my computer, and yes JabRef couldn't find TeXworks. But my fix solved this issue. Oh, there seems some conflict in branch. What does this exactly mean? The new code for MathSci is not in its own branch, can it be the reason of the conflict? |
Added log line |
Thanks, please resolve the conflicts now (merge upstream/main in your branch) |
# Conflicts: # build.gradle # src/main/java/module-info.java
Can you help me a little bit? I've merged UPDATE: |
You fixed the merge conflicts, so the only commit is the adjusted merge commit with your resolved changes. So, all done. |
Closes #10977.
I added
mslinks
package as a dependency:implementation
line inbuild.gradle
file andrequires
line inmodule-info.java
.Then, I edited the
detectProgramPath
function inorg.jabref.gui.desktop.os.Windows.
to handle TeXworks as a special case. It checks whether the link is present, and then extracts the target from link by usingmslinks
package. In case if the link is not present or there was some error while reading the link file the function fallbacks to default behaviour.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)That is my first Pull Request and I am sorry if I missed something. There is some cluttering with commits and branches, because I forgot to start a new branch and edit
CHANGELOG.md
, will that be a problem?