-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fixing add_fixed_in_frame_mobjects
#569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
pr:bugfix
Bug fix for use in PRs solving a specific issue:bug
Comments
This was referenced Oct 19, 2020
Yeah, I was getting the error: |
BrendanMartin
added a commit
to BrendanMartin/manim
that referenced
this issue
Nov 3, 2020
leotrs
added a commit
that referenced
this issue
Nov 6, 2020
* Fix for #569 Co-authored-by: kolibril13 <jan-hendrik.mueller@gmx.net>
Fixed via #674. |
suhailsherif
added a commit
to suhailsherif/manim
that referenced
this issue
Jul 21, 2021
hydrobeam
added a commit
that referenced
this issue
Jul 30, 2021
* Putting frame_center in the center of the frame * Update the scene whenever frame_center moves. * Make the frame_center point invisible (no stroke). * Extending the fix for #569 to 2 similar scenarios. * Modified CameraMoveTest, fixes to 3d cam access * Whoops, made a mistake with a partial add * Added docstrings, type hints * Apply suggestions from code review Co-authored-by: Laith Bahodi <70682032+hydrobeam@users.noreply.github.com> * Implementing suggestions from code review. * Performance improvement when frame center is stationary Co-authored-by: Laith Bahodi <70682032+hydrobeam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This script is currently broken because add_fixed_in_frame_mobjects throws an error.
It was broken before but fixed by #281.
Now, with
git bisect
I could boil down the first occurrence of this error to this pr:#532 (ping to @eulertour)
Before that, the Text3D Scene was functioning properly.
It would be nice when we could make this work again :)
As soon as we have it fixed, I can volunteer to add a test for this.
The text was updated successfully, but these errors were encountered: