Skip to content

Fixing add_fixed_in_frame_mobjects #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kolibril13 opened this issue Oct 19, 2020 · 2 comments
Closed

Fixing add_fixed_in_frame_mobjects #569

kolibril13 opened this issue Oct 19, 2020 · 2 comments
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Comments

@kolibril13
Copy link
Member

class Text3D(ThreeDScene):
    def construct(self):
        axes = ThreeDAxes()
        self.set_camera_orientation(phi=75 * DEGREES,theta=-45*DEGREES)
        text=TextMobject("This is a 3D text")
        self.add_fixed_in_frame_mobjects(text.to_corner(UL))
        self.add(axes)
        self.add(text)
        self.wait()

This script is currently broken because add_fixed_in_frame_mobjects throws an error.
It was broken before but fixed by #281.
Now, with git bisect I could boil down the first occurrence of this error to this pr:
#532 (ping to @eulertour)
Before that, the Text3D Scene was functioning properly.
It would be nice when we could make this work again :)
As soon as we have it fixed, I can volunteer to add a test for this.

@BrendanMartin
Copy link
Contributor

Yeah, I was getting the error:
AttributeError: 'ThreeDCamera' object has no attribute 'extract_mobject_family_members'
and found in #532 there's a change to camera.py where extract_mobject_family_members was moved:
https://github.com/ManimCommunity/manim/pull/532/files#diff-7732083ebe3bdfdbb948a293a8ff761e5c4a7b8ed98e1daed6838076a4781234L366

BrendanMartin added a commit to BrendanMartin/manim that referenced this issue Nov 3, 2020
@BrendanMartin BrendanMartin mentioned this issue Nov 3, 2020
1 task
leotrs added a commit that referenced this issue Nov 6, 2020
* Fix for #569

Co-authored-by: kolibril13 <jan-hendrik.mueller@gmx.net>
@behackl
Copy link
Member

behackl commented Nov 16, 2020

Fixed via #674.

@behackl behackl closed this as completed Nov 16, 2020
suhailsherif added a commit to suhailsherif/manim that referenced this issue Jul 21, 2021
hydrobeam added a commit that referenced this issue Jul 30, 2021
* Putting frame_center in the center of the frame

* Update the scene whenever frame_center moves.

* Make the frame_center point invisible (no stroke).

* Extending the fix for #569 to 2 similar scenarios.

* Modified CameraMoveTest, fixes to 3d cam access

* Whoops, made a mistake with a partial add

* Added docstrings, type hints

* Apply suggestions from code review

Co-authored-by: Laith Bahodi <70682032+hydrobeam@users.noreply.github.com>

* Implementing suggestions from code review.

* Performance improvement when frame center is stationary

Co-authored-by: Laith Bahodi <70682032+hydrobeam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
Development

No branches or pull requests

3 participants