Skip to content

# Changes in camera.py to fix fixed frame option in 3D #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

kolibril13
Copy link
Member

There was an issue with z_index and add_fixed_in_frame_mobjects (#264). This change will fix it.
Can be tested with

from manim import *
class Text3D(ThreeDScene):
    def construct(self):
        axes = ThreeDAxes()
        self.set_camera_orientation(phi=75 * DEGREES,theta=-45*DEGREES)
        text=TextMobject("This is a 3D text")
        self.add_fixed_in_frame_mobjects(text.to_corner(UL))
        self.add(axes)
        self.add(text)
        self.wait()

from pathlib import Path
if __name__ == "__main__":
    script = f"{Path(__file__).resolve()}"
    os.system(f"manim  -p -s  " + script )

@leotrs
Copy link
Contributor

leotrs commented Aug 14, 2020

Can you please tell us what was the bug that this is fixing?

@kolibril13
Copy link
Member Author

kolibril13 commented Aug 14, 2020

Something went wrong in the sort method, see #264 .
I changed the line @PgBiel suggested and no error message anymore. But I did not do further testing.

@PgBiel PgBiel added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants