No BuildMachines #64
Merged
No BuildMachines #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 We can also get rid of the SystemTypes table. [Edit: ah, you said that...] @rbvermaa Since you once added the UI for managing machines: are you very attached to that? |
Merged
|
Not really, but please ask around on #nixos if civodil or mornfall are using the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch gets rid of all in-hydra management of build machines. Keeping two separate databases of build machine information safely in sync is more work than it's worth, especially since the build hook doesn't care about the BuildMachines. Instead, when build machine information is needed, parse it out of /etc/nix.machines (checking NIX_REMOTE_SYSTEMS first). Administrators should manage /etc/nix.machines out-of-band.
Along similar lines, I plan on getting rid of the SystemTypes table and having the queue runner use nix.machines to see the number of build hooks per system.