No SystemTypes #65
Merged
No SystemTypes #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to determine how many build jobs are allowed per system type. Note that on machines that support multiple system types, EACH system type gets the full number of build slots, which is almost certainly not what we want.
grahamc
added a commit
to DeterminateSystems/hydra
that referenced
this pull request
Oct 25, 2021
…, but put back in fcd511c, and now totally unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #64, this branch removes the SystemTypes table, instead getting the number of build slots per system type from machines.nix.
Note that on machines that support multiple system types, EACH system type gets the full number of build slots, which is almost certainly not what we want, but a good solution to that problem will require adjusting the available build hooks based on actual load on the remote machines.