[18.0][MIG] web_responsive: Migration to 18.0 #3037

kobros-tech · 2024-12-24T17:58:40Z

No description provided.

kobros-tech · 2024-12-24T21:22:20Z

The issue is inside web_pivot_computed_measure module tests.
I introduced a PR of a fix to the tests #3038

chaule97 · 2025-01-22T03:30:20Z

Hi, I opened another PR #3057, welcome you review it

kobros-tech · 2025-01-24T15:23:07Z

@chienandalu
@CarlosRoca13

I referred to you in another PR that is a dependency for this PR tests

CarlosRoca13 · 2025-01-27T14:59:08Z

Please, note this pr #3069

web_responsive/static/tests/test_patch.js

eslint.config.cjs

* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive

* Bump version * Change all openerp to odoo * Fix qunit suite injection * Remove jQuery require * Change to new selectors: * `oe_leftbar` to `o_sub_menu` * `oe_logo` to `o_sub_menu_logo` * `oe_footer` to `o_sub_menu_footer` * `oe_secondary_menus_container` to `o_sub_menu_content` * Add style to hide oe_footer instead of remove to not break `support_branding` * Add note in ReadMe explaining override of `support_branding` * Set top margin of app drawer title to 0 to fit v10 proportions * Fix notification badge positioning * Add o_web_client class to body to fix overlaps * Scroll control panel with page * Change navbar z-index to not be overlapped by buttons * Raise z-index on header to raise over buttons * Handle layered notifications via z-index * Remove `#` from navigation links HREF to prevent history littering

* Rebalance z-indexes to fix overlay issue while still providing notification support

* Bold titles for apps in the app-drawer * Remove z-index from Control Panel buttons, so it doesn't overlap the menu. * Better responsive menus * Move systray icons/menus out of the menu and up to the top bar. * Increase avatar size and visibility. * Other minor menu behavior fixes. * Changes to fit odoo variables * And a little margin adjust on navbar-right * Top menu always thick * Removed overflow:hidden!important from main.less * Local patch: prevent body overflow auto * Stop using `style=` on `<body>` * Fix jquery drawer in anticipation of: blivesta/drawer#36

On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens

Make image editing controls always available, instead of depending on resolution or hover.

Small makeup to make it look good in XS screens.

* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change

* Change accesskey for `edit` in form view back to `e` to fix OCA#587

Before this patch, there was an incompatibility between this addon and l10n_es_toponyms, caused by the lack of wrapping of the special address field that was being added. Now layout works as expected in that case. In any other case, it seems sensible to wrap inputs so no more weird overflows happen and less chances of needing horizontal scrolling happen.

* Initial commit * Initial commit

pedrobaeza · 2025-04-11T06:17:12Z

This migration still loses the preview display that is not opening automatically the attachments (for example in invoices), and that has the previous possibilities. Please restore that behavior.

kobros-tech · 2025-04-11T06:37:57Z

This migration still loses the preview display that is not opening automatically the attachments (for example in invoices), and that has the previous possibilities. Please restore that behavior.

yes, its a bug here
I will work on it

kobros-tech · 2025-04-11T07:08:00Z

This migration still loses the preview display that is not opening automatically the attachments (for example in invoices), and that has the previous possibilities. Please restore that behavior.

There was an issue with scss, on my side I saw chatter is taking 90% of the page I am still seeing document but in the big view only.

please check again if you don't see the document try to minimize the fonts or maximize the resolution.

chaule97 · 2025-04-14T04:09:44Z

Hi @kobros-tech , I have created refactor code PR kobros-tech#1 in your repo. Please review, merge and squash it

etobella · 2025-04-17T13:18:46Z

@kobros-tech I made a basic functional test and everything looks great. What is missing?

kobros-tech · 2025-04-17T13:24:04Z

@kobros-tech I made a basic functional test and everything looks great. What is missing?

@etobella
Thanks very much, I think nothing is missing after I compared my PR to another one.
I did changes requested by reviewers and merged some commits here as requested and merged in 17.0 too.

pedrobaeza

Please avoid this ugly view if no icon defined:

And this is still not covering the requirement of not auto-showing attachment for example in invoices:

and you have to use the other preview "style" where you can maximize it. Why are you ignoring me on this?

kobros-tech · 2025-04-17T16:36:28Z

@pedrobaeza

after I ran tests twice I confirm the timeout issue is solved by increasing the step_delay, reference:
https://github.com/odoo/odoo/blob/18.0/addons/im_livechat/tests/test_chatbot_form_ui.py#L42

PR:
#3158

kobros-tech · 2025-04-17T16:49:32Z

@pedrobaeza
good idea to add a default icon similar to modules don't have icons.

but for the preview, if I didn't understand you or I did and having it fine.

as if I zoom out screen it pops up and if I zoom in the previow goes away, and I will record a video to show.

kobros-tech · 2025-04-17T16:50:58Z

@pedrobaeza

I can't ignore you, but sometimes I misunderstand or unable to answer if I have a good answer.
I am sorry really.

kobros-tech · 2025-04-17T16:58:11Z

Preview in invoices screen:

web_responsive_preview.mp4

pedrobaeza · 2025-04-17T17:01:38Z

I already stated in #3057 (review) and here in #3037 (comment).

My initial comment with detailed explanation: #2405 (comment)

Extracted from there:

Document viewer

Odoo includes natively the possibility of viewing in an embedded popup PDF files, videos or images. On previous versions, as the community edition always put the chatter on the bottom, these documents were previewed full size, covering the contents and not letting you to work side by side.

web_responsive then included code for working on a more similar way than enterprise: putting the document viewer on the side, for easing the input for example on vendor bills, copying things side by side:

But it was also decided to do it in a more convenient way:
- Don't opening by default the so considered main attachment by Odoo. This is not always what you want to do, and it covers the conversation (or move it to the bottom, being not consistent where to find it).
- Allow to display this way any of the attachments, not only what they consider the main one.
Odoo has now included these enterprises features in the community edition, but they use a different "document viewer" for the side view, and it still has the first mentioned flaw. So I think we need to tackle this in the OCA module. Possible options:
1. Disable the "side viewer", and use the main document viewer in the same way as in previous versions.
2. Don't move the chatter to bottom, don't open the side viewer in any case, opening it when clicking the attachments, and put a close X icon on the side viewer to "return" to the chatter.

See also #2745, and how it was added in 17 in #2795

pedrobaeza · 2025-04-17T17:08:42Z

@kobros-tech I insist: the problem is the automatic display of that preview in the invoices. It should be disabled by default. We want the preview, but not automatic. Do you understand me?

pedrobaeza · 2025-04-17T17:13:17Z

And that automatic preview is not using the same stuff:

kobros-tech · 2025-04-17T17:56:03Z

let me understand this and see what I can do, at least to try.

kobros-tech · 2025-04-17T18:03:40Z

@pedrobaeza

I did try odoo without web_responsive and with it.

I saw the preview is poping up automatically, and in case of clicking the attachment the big screen of it pops up.

If I catch your point, I am asked to disable the default one but keeping the function if I click on attachmen?

becaue of the pros of the one we see when cliking on attachment over the other auto one?

If I am correct ok, I will try.

pedrobaeza · 2025-04-17T18:15:27Z

I am asked to disable the default one but keeping the function if I click on attachmen?

Yes. This is what we have as part of web_responsive module since a lot of versions ago, and what you have to keep migrating the module. It's not something new that is asked.

becaue of the pros of the one we see when cliking on attachment over the other auto one?

Yes, already explained in quotes, but summarizing:

Chatter visible without scrolling.
Maximize possibility.
Be able to see this way more than one attachment, not the main one.

kobros-tech mentioned this pull request Dec 24, 2024

[18.0][FIX] web_pivot_computed_measure: fix tests #3038

Merged

kobros-tech mentioned this pull request Dec 25, 2024

[18.0][BUG] web_pivot_computed_measure: unit tests fail and cause another module migration to fail #3039

Open

kobros-tech force-pushed the 18.0-mig-web_responsive branch 3 times, most recently from ac1f548 to daaafd6 Compare January 24, 2025 08:55

carlos-lopez-tecnativa suggested changes Jan 27, 2025

View reviewed changes

web_responsive/static/tests/test_patch.js Outdated Show resolved Hide resolved

web_responsive/static/tests/test_patch.js Outdated Show resolved Hide resolved

carlos-lopez-tecnativa suggested changes Jan 27, 2025

View reviewed changes

web_responsive/static/tests/test_patch.js Outdated Show resolved Hide resolved

eslint.config.cjs Outdated Show resolved Hide resolved

kobros-tech force-pushed the 18.0-mig-web_responsive branch 3 times, most recently from 804cb3f to 786da5e Compare January 27, 2025 21:29

lasley and others added 16 commits January 28, 2025 01:31

[FIX] web_responsive: Other minor fixes

e2013b2

* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive

[FIX] web_responsive: Change z-indexes

a57604f

* Rebalance z-indexes to fix overlay issue while still providing notification support

Form view improvements to fit smaller screens

0133990

On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens

Form image editing controls always present

8d26f7e

Make image editing controls always available, instead of depending on resolution or hover.

Fix problem with overflowing chatter widget.

a5f8815

[FIX][web_responsive] Form padding, titles and buttons OK in XS

8ba347f

Small makeup to make it look good in XS screens.

[10.0][IMP][web_responsive] (OCA#569)

206a55f

* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change

Update README to fix wikipedia link

9d94a90

[FIX] web_responsive: Change edit accesskey

0e8881f

* Change accesskey for `edit` in form view back to `e` to fix OCA#587

[FIX] web_responsive: Execution permission

64633d0

[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)

3611363

* Initial commit * Initial commit

[FIX][web_responsive] Long-named multicompanies nice in XS (OCA#688)

d95cee1

[10.0][IMP] web_responsive: Load default kanban view for small screen

14c39a8

kobros-tech force-pushed the 18.0-mig-web_responsive branch from 8555e0b to 85f2334 Compare April 11, 2025 05:41

kobros-tech requested a review from carlos-lopez-tecnativa April 11, 2025 05:49

kobros-tech force-pushed the 18.0-mig-web_responsive branch from 85f2334 to 3d7aad1 Compare April 11, 2025 07:05

kobros-tech force-pushed the 18.0-mig-web_responsive branch from 3d7aad1 to e49566d Compare April 17, 2025 13:28

[18.0][MIG] web_responsive: Migration to 18.0

37d27dd

kobros-tech force-pushed the 18.0-mig-web_responsive branch from e49566d to 37d27dd Compare April 17, 2025 13:32

etobella approved these changes Apr 17, 2025

View reviewed changes

kobros-tech force-pushed the 18.0-mig-web_responsive branch 2 times, most recently from 71115d2 to 1ff2104 Compare April 17, 2025 15:05

kobros-tech mentioned this pull request Apr 17, 2025

[18.0][IMP] web_pivot_computed_measure: increate test tour delay time #3158

Merged

pedrobaeza requested changes Apr 17, 2025

View reviewed changes

kobros-tech force-pushed the 18.0-mig-web_responsive branch from 1ff2104 to 37e6232 Compare April 17, 2025 16:24

[Don't Merge] test-requirements

284a6c7

kobros-tech force-pushed the 18.0-mig-web_responsive branch from 37e6232 to 284a6c7 Compare April 17, 2025 16:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] web_responsive: Migration to 18.0 #3037

[18.0][MIG] web_responsive: Migration to 18.0 #3037

kobros-tech commented Dec 24, 2024

kobros-tech commented Dec 24, 2024

chaule97 commented Jan 22, 2025

kobros-tech commented Jan 24, 2025

CarlosRoca13 commented Jan 27, 2025

pedrobaeza commented Apr 11, 2025

kobros-tech commented Apr 11, 2025

kobros-tech commented Apr 11, 2025 •

edited

Loading

chaule97 commented Apr 14, 2025

etobella commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

pedrobaeza left a comment

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

pedrobaeza commented Apr 17, 2025

pedrobaeza commented Apr 17, 2025

pedrobaeza commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

pedrobaeza commented Apr 17, 2025

[18.0][MIG] web_responsive: Migration to 18.0 #3037

Are you sure you want to change the base?

[18.0][MIG] web_responsive: Migration to 18.0 #3037

Conversation

kobros-tech commented Dec 24, 2024

kobros-tech commented Dec 24, 2024

chaule97 commented Jan 22, 2025

kobros-tech commented Jan 24, 2025

CarlosRoca13 commented Jan 27, 2025

pedrobaeza commented Apr 11, 2025

kobros-tech commented Apr 11, 2025

kobros-tech commented Apr 11, 2025 • edited Loading

chaule97 commented Apr 14, 2025

etobella commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

pedrobaeza left a comment

Choose a reason for hiding this comment

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

Preview in invoices screen:

pedrobaeza commented Apr 17, 2025

pedrobaeza commented Apr 17, 2025

pedrobaeza commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

pedrobaeza commented Apr 17, 2025

kobros-tech commented Apr 11, 2025 •

edited

Loading