Skip to content

First merge from develop branch to main #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 144 commits into
base: main
Choose a base branch
from
Open

First merge from develop branch to main #31

wants to merge 144 commits into from

Conversation

bhargavakula01
Copy link
Collaborator

Need to start moving some of our changes into the main branch as we continue developing

At11011 and others added 30 commits June 22, 2024 17:05
… for unit test cases for the components module
Implementation of mass_balance_check() and energy_balance_check() trait functions in blocks module
moved the IdealGasPackage struct into its own file and made it into a
submodule of the thermodynamics module. In the future, as more packages
are implemented, one simply needs to create another sub-module when
implementing a new thermodynamics package
implemented function for entropy calculation for the ideal gas package.
Need to look into how to incorporate the mass and mole fraction
functions within the thermo packages and ensure that the thermopackage
structs and the 'ThermoState' package are working together cohesively
…rait

Felt those functions were unncessary as the changes in volume and moles
would be attributed to reactions. This would be something implmeneted
within the block structs rather than the thermoState struct, which
should mostly be about holding relevant thermodynamic equations.
… volume calculation under different EOS and based on vapor and liquid fractions
basically made it so that it will always return 1 for the vapor fraction
function as one would only use the ideal gas package when working with
only gaseous components and no liquid components.
need to figure out a way to calculate Cv for internal energy function
@bhargavakula01 bhargavakula01 added the enhancement New feature or request label Mar 29, 2025
@bhargavakula01 bhargavakula01 self-assigned this Mar 29, 2025
@bhargavakula01 bhargavakula01 changed the title Develop First merge from develop branch to main Mar 29, 2025
@bhargavakula01 bhargavakula01 marked this pull request as ready for review May 10, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants