-
Notifications
You must be signed in to change notification settings - Fork 0
First merge from develop branch to main #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bhargavakula01
wants to merge
144
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project layout added
Additional features
… for unit test cases for the components module
Implementation of mass_balance_check() and energy_balance_check() trait functions in blocks module
… external package pubchem.rs from crates.io
moved the IdealGasPackage struct into its own file and made it into a submodule of the thermodynamics module. In the future, as more packages are implemented, one simply needs to create another sub-module when implementing a new thermodynamics package
implemented function for entropy calculation for the ideal gas package. Need to look into how to incorporate the mass and mole fraction functions within the thermo packages and ensure that the thermopackage structs and the 'ThermoState' package are working together cohesively
…t matching the uml design
…rait Felt those functions were unncessary as the changes in volume and moles would be attributed to reactions. This would be something implmeneted within the block structs rather than the thermoState struct, which should mostly be about holding relevant thermodynamic equations.
… volume calculation under different EOS and based on vapor and liquid fractions
basically made it so that it will always return 1 for the vapor fraction function as one would only use the ideal gas package when working with only gaseous components and no liquid components.
need to figure out a way to calculate Cv for internal energy function
Adding a GNU v3.0 licence to the project Signed-off-by: Bhargav Akula <62191542+bhargavakula01@users.noreply.github.com>
consolidated streams into 1 struct
Adding gnu license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to start moving some of our changes into the main branch as we continue developing