Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light dom container #3697

Merged
merged 34 commits into from
Jun 28, 2024
Merged

Light dom container #3697

merged 34 commits into from
Jun 28, 2024
+237 −130

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Apr 15, 2024

no-shadow option for luigi container

@JohannesDoberer JohannesDoberer self-assigned this Apr 17, 2024
@JohannesDoberer JohannesDoberer marked this pull request as ready for review June 3, 2024 21:13
@JohannesDoberer JohannesDoberer added documentation documentation tasks enhancement New feature or request labels Jun 5, 2024
walmazacn
walmazacn approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ndricimrr
ndricimrr approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested out and works well 👍

This was referenced Jun 20, 2024
Merged
Closed
@walmazacn
Copy link
Contributor

LGTM - all tests are passing and build is successful 👍

@walmazacn
Copy link
Contributor

Everything looks good after latest changes

@JohannesDoberer JohannesDoberer merged commit de44656 into main Jun 28, 2024
12 checks passed
@JohannesDoberer JohannesDoberer deleted the light-dom-container branch June 28, 2024 11:51
@JohannesDoberer JohannesDoberer mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smahati smahati smahati left review comments

@ndricimrr ndricimrr ndricimrr approved these changes

@walmazacn walmazacn walmazacn approved these changes

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa

Assignees

@JohannesDoberer JohannesDoberer

Labels
container documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hardl @walmazacn @ndricimrr @smahati @JohannesDoberer