Add getToken function support to Luigi Container #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…84-getToken-function
ndricimrr
commented
Jun 20, 2024
ndricimrr
commented
Jun 20, 2024
ndricimrr
requested review from
hardl,
JohannesDoberer,
VincentUllal,
smahati,
walmazacn and
amilewskaa
as code owners
|
EDIT: Can be reviewed |
walmazacn
reviewed
Jul 3, 2024
walmazacn
reviewed
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
add capability to use the getToken function inside the iframe based container
Sends a message to the container iframe based microfrontend to set the auth data. This allows LuigiClient to receive the token through the getToken function inside the microfrontend.
Added Cypress tests
Added unit tests
Potential future merge conflict with Light DOM Container PR since it affects LuigiContainer.svelte files due to the new Prettier for Svelte options recently added - merge that one first and resolve Merge Conflicts here afterward, to make reviewing this PR easier.
Related issue(s)
Resolves #3784