Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

feature request: split user_permission/manage_namespace #1109

Closed
AndreasUfert opened this issue Oct 25, 2016 · 4 comments
Closed

feature request: split user_permission/manage_namespace #1109

AndreasUfert opened this issue Oct 25, 2016 · 4 comments
Assignees
Labels

Comments

@AndreasUfert
Copy link

As of Portus 2.1 user_permission/manage_namespace/enabled=false enforces both, only administrators can manage namespaces (which is fine) and only administrators can add webhooks for namespaces.

The feature request is to split this permission in a way that only administrators can manage namespaces if user_permission/manage_namespace/enabled is set to false, but still users are able to manage webhooks for a particulat namespace. This permission could be linked to the "Owner" role of the associated team.

@mssola mssola added the feature label Oct 27, 2016
@mssola
Copy link
Collaborator

mssola commented Oct 27, 2016

Makes sense

@holgerreif
Copy link

There is another right, which is tied to user_permission/manage_namespace/enabled and should be separated: The right to edit the description of the namespace.

The main thing I'm concerned about namespace management is the polution with miss-spelled names, just-test-names or miss-taken names.

Maybe it would make sense to have the following different settings for user_permission/manage_namespace/enabled:

  • none: user cannot do anything
  • modify (or edit): user is allowed to add webhooks and description (and what else?) and is allowed to delete a namespace (although later could be linked to create right)
  • create: user is allowed to create a new namespace

@mssola
Copy link
Collaborator

mssola commented Nov 17, 2016

Seems like a good idea 👍

@mssola mssola added this to the Release 2.3 milestone Aug 2, 2017
@mssola mssola modified the milestones: Release 2.3, Release 2.4 Sep 19, 2017
mssola added a commit to mssola/Portus that referenced this issue May 2, 2018
Before this commit, permissions on webhooks were coupled with
namespaces, which was not desirable for some users.

Fixes SUSE#1109

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
@mssola
Copy link
Collaborator

mssola commented May 2, 2018

A couple of things after #1806 was merged.

The right to edit the description of the namespace.

I discarded this, because it's too specific. It shouldn't be too bad that it's under manage_namespace.

As for the other split (between create and manage), this has already been implemented in other releases and it's already available in 2.3.

Thanks for the feedback 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants