This repository was archived by the owner on Apr 17, 2023. It is now read-only.
webhooks: added permissions on webhooks #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, permissions on webhooks were coupled with namespaces, which was not desirable for some users. Fixes SUSE#1109 Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
vitoravelino
reviewed
May 2, 2018
|
|
||
| protected | ||
|
|
||
| def create_or_manage?(perm) |
There was a problem hiding this comment.
Maybe just can?? It's a local thing, so I guess it's fine. What do you think?
There was a problem hiding this comment.
I thought about it, but then I realized that it might be confusing, because it's not valid for show, for example. So, I'd rename it only if we add more stuff into it with the same implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, permissions on webhooks were coupled with
namespaces, which was not desirable for some users.
Fixes #1109
Signed-off-by: Miquel Sabaté Solà msabate@suse.com