This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Return nil for tags on unsuccessful catalogs #1293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we try to fetch the tags of a given repository, set the "tags" value to nil for repositories for which the request was unsuccessful. This is already handled by the CatalogJob as a way to skip it. This way, we avoid removing repos when a 401 response has been returned when accessing the catalog. Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola
changed the title
|
I changed my code and checked that CatalogJob works fine. |
mssola
added a commit
to mssola/Portus
that referenced
this pull request
Apr 17, 2018
This commit is more explicit on what to do when a catalog error happens. In this case, if a plain catalog error happens (fetching the list of repositories and their manifests), then nothing will be done. If fetching the catalog worked, and fetching the list of tags then suddenly fails, before this commit that repo would've get nuked because it would've get a repository with no tags. This commit instructs to skip that repository when considering whether to remove or not some repositories that are found to be dangling. See SUSE#1293 See SUSE#1599 Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola
added a commit
to mssola/Portus
that referenced
this pull request
Apr 18, 2018
This commit is more explicit on what to do when a catalog error happens. In this case, if a plain catalog error happens (fetching the list of repositories and their manifests), then nothing will be done. If fetching the catalog worked, and fetching the list of tags then suddenly fails, before this commit that repo would've get nuked because it would've get a repository with no tags. This commit instructs to skip that repository when considering whether to remove or not some repositories that are found to be dangling. See SUSE#1293 See SUSE#1599 Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola
added a commit
that referenced
this pull request
Apr 18, 2018
This commit is more explicit on what to do when a catalog error happens. In this case, if a plain catalog error happens (fetching the list of repositories and their manifests), then nothing will be done. If fetching the catalog worked, and fetching the list of tags then suddenly fails, before this commit that repo would've get nuked because it would've get a repository with no tags. This commit instructs to skip that repository when considering whether to remove or not some repositories that are found to be dangling. See #1293 See #1599 Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we try to fetch the tags of a given repository, set the "tags"
value to nil for repositories for which the request was unsuccessful.
This is already handled by the CatalogJob as a way to skip it. This way,
we avoid removing repos when a 401 response has been returned when
accessing the catalog.
Signed-off-by: Miquel Sabaté Solà msabate@suse.com