This repository was archived by the owner on Apr 17, 2023. It is now read-only.
sync: do not remove repositories on some errors #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit depends on #1782. Do not merge it before merging that other one. |
This commit is more explicit on what to do when a catalog error happens. In this case, if a plain catalog error happens (fetching the list of repositories and their manifests), then nothing will be done. If fetching the catalog worked, and fetching the list of tags then suddenly fails, before this commit that repo would've get nuked because it would've get a repository with no tags. This commit instructs to skip that repository when considering whether to remove or not some repositories that are found to be dangling. See SUSE#1293 See SUSE#1599 Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola
force-pushed
the
safer-update-catalog
branch
from
afca581 to
b976361
Compare
|
Now this can be reviewed 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is more explicit on what to do when a catalog error happens.
In this case, if a plain catalog error happens (fetching the list of
repositories and their manifests), then nothing will be done. If
fetching the catalog worked, and fetching the list of tags then suddenly
fails, before this commit that repo would've get nuked because it
would've get a repository with no tags.
This commit instructs to skip that repository when considering whether
to remove or not some repositories that are found to be dangling.
See #1293
See #1599
Signed-off-by: Miquel Sabaté Solà msabate@suse.com