Specify the version refers to SCF in @since annotations
#129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
approved these changes
May 13, 2025
priethor
added a commit
that referenced
this pull request
May 14, 2025
priethor
added a commit
that referenced
this pull request
May 14, 2025
priethor
added a commit
that referenced
this pull request
May 14, 2025
* First attempt at adding command palette support * Command polishing * Add commands for registered CPTs * Refactor * Refactor to use wp.scf * Refactor * Refactor to pass the data in acf.data.customPostTypes * Fix redirections * Check capabilities before registering comands Includes a refactor to divide commands between core and post-type based: core commands require admin permissions, whereas post-types are dynamic and depend on their own capabilities. * Filter post types that don't enable the setting "show in UI" * Redo webpack config linting * Redo webpack linting * Apply linting * Polish * Refactor * Fix coding standards in comments * Ensure we only register the commands when the palette is available * Refactor to remove scf and acf prefixes, organizing files in folders similar to modules * Optimize return early * Remove unnecessary script registration * Use the `scf` prefix in admin commands. * Use `scf` prefix for CPT commands * Only pass CPTs to the frontend when the array is not empty * CPT commands: only add label as a keyword if not empty * Polish * Refactor the depencies to user import statements * Optimize scripts loading and execution - Defer the script loading (defer was introduced in WP 6.3) - Defer script execution by using the priority queue (introduced in WP 5.0) Since the scripts will only be registered in versions with Command API support, which is 6.3+, we can use both * Update package-lock.json * Slight refactor * Assets: remove redundant registrations, prefix registered scritps * Remove redundant admin check * Remove unnecesary checking of `acf_get_acf_post_types` * Change the priority queue to a simpler `requestIdleCallback` * Update assets/src/js/commands/custom-post-type-commands.js * Improved URL building * Fix command labels for better i18n * Simplify label calculation leveraging WP core functions * Remove redundant client-side label calculation * Fixed `@since` annotations to follow the steps of #129 * Switch to using the proper labels for the commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6.
What
This PR changes all the
@sinceannotations and comments to specify they refer to SCF (or ACF for older versions), not WordPress.Why
This will help in two ways:
@since 6.5refers to WordPress 6.5.Testing instructions
No specific testing needed, but if you are using AI agents, you can ask things like
When was [function] introduced?and see the difference.