Don't swallow model errors in streaming mode #270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| line.delete_prefix!("data: ") | ||
| user_proc.call(JSON.parse(line)) | ||
| end | ||
| elsif chunk.include?('"error": ') |
There was a problem hiding this comment.
don't know 100% how it works, but can it just return me some JSON examples with this string?
There was a problem hiding this comment.
raw chunk: {
"error": {
"message": "The model `gpt-3.5-turbo!!!!` does not exist",
"type": "invalid_request_error",
"param": null,
"code": null
}
}
3 tasks
|
FYI I have an open PR to solve the same issue, using a different approach: #275 |
Merge to current release
codenamev
reviewed
Aug 29, 2023
| rescue JSON::ParserError | ||
| # Ignore invalid JSON. | ||
| proc do |chunk, overall_received_bytes, env| | ||
| Rails.logger.debug("raw chunk: #{chunk}") |
There was a problem hiding this comment.
Please remove references to Rails. It's not a dependency and will cause issues for anyone using this outside of Rails.
I've created a new issue (#320) to track adding a logger, and this can be added there.
|
I'm working on properly fixing these issues with #338 (and I'll follow up with a breaking change to raise actual exceptions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
I lost a lot of time and suffered needless premature aging until putting this change into place on my project. A bug was causing context overflows and the current release of the library swallows those errors.
Credit to @lingceng for the solution in #256