-
-
Notifications
You must be signed in to change notification settings - Fork 361
Raise exceptions #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise exceptions #344
Conversation
a27656c
to
2b85439
Compare
Thanks @atesgoral - taking a look now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this!
Fixed a couple of errors but that spec is still failing due to Faraday raising the error 🤔 |
@alexrudall We might need to pass in a full-fledged mock Request object. I'll poke around. |
Legend, thank you |
Ah, I just remembered removing that HTTP error case from the http spec because I was running into issues with mocking a request. I then added a VCR at the client spec level instead. The old test might have popped back in due to a bad rebase. I removed it again. |
All Submissions: