This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(jasmine): Pass controlflow to jasminewd #3517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- temporarily add typings for selenium-webdriver.d.ts - include selenium-webdriver dependency to built/index.d.ts - add webdriver typings to locators - update example and spec/install to not use typings.json - spec test updated to get the tsc test to pass - includes clang formatting fixes
Fixes angular#3045. Since mocha 2.4.1, we should be wrapping global.it.only.
- include node and jasmine dependency to built/index.d.ts - update example and spec/install to not need @types/jasmine and @types/node to install - add more selenium-webdriver to gulp task - added an interface in globals for Error to include a code and stack - improve webdriver typings to elements and browser
heathkit
force-pushed
the
pass-controlflow
branch
from
92b2a7f to
571ae5a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3505, which is caused by JasmineWd and Protractor using different controlflow instances.