-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Docs rewrite rules #9325
[v2] Docs rewrite rules #9325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Also had the same comment about the absolute URI previously used, but that was taken care of.
I think you could run the pre-commit
hook on these and the issues I saw would get taken care of, maybe some more still.
Since you already have committed, you can do this to run
Reference from https://pre-commit.com/ under "Some example useful invocations". |
Co-authored-by: Kenneth Daily <kdaily@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #9325 +/- ##
==========================
==========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description of changes:
package.redirects.conf
file containing Apache redirect rules for each documented service operation supported by the AWS CLI v2.conf.py
file's extensions list so that it is invoked during executions of Sphinx build.Description of tests:
make all
).package.redirects.conf
file is generated to our build output folder/doc/build/html/package.redirects.conf
.package.redirects.conf
in its root.Test script used for verifying correctness of the generated file's contents:
After generating the redirects file via
make all
using the extension added in this PR, I observed the following output from running this script:pinpoint-sms-voice
, since it is a copy of the servicesms-voice
. These 8 are all of the duplicate modeled operations.pinpoint-sms-voice-2018-09-05/ListConfigurationSets$
. This can be explained by the fact that the CLI v2 does not currently support this operation as of testing.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.